alan-turing-institute / reginald

Reginald repository for REG Hack Week 23
3 stars 0 forks source link

Decide which arguments should be set using defaults #87

Closed rwood-97 closed 12 months ago

rwood-97 commented 1 year ago

Currently, we don't set defaults for many of our arguments in run.py to allow users to set them using env variables. We should go through and decide which ones we want to be this way and which should just be defaults. Potentially for consistency all should be able to be set using environment variables.

rwood-97 commented 1 year ago

Maybe we could have:

   parser.add_argument(
        "--mode",
        type=str,
        help=(
            "Select which mode to use "
            "(ignored if not using llama-index-llama-cpp or llama-index-hf). "
            "Default is 'chat'."
        ),
        default=os.environ.get("LLAMA_MODE") or "chat",
        choices=["chat", "query"],

Behaviour:

rchan26 commented 1 year ago

this is a nice idea - will try!