Integration testing - Githubissues

alan-turing-institute / simulate-frontend

Simulate frontend application.

http://simulate.readthedocs.io

0 stars 1 forks source link

Integration testing #42

Closed myyong closed 6 years ago

myyong commented 7 years ago

Comments refer to branch 42-integration-testing

masonlr commented 7 years ago

[ ] transparent/greyed out "save" button when state is clean. Opaque "save" button when status is dirty
[ ] remove console.log() statements
[x] it should not be possible to edit a submitted job
[x] clicking Send job takes the user to a blank page (?)

'Run job' (previously send) takes user to output page
[ ] use moments.js or similar (https://momentjs.com/) to display user friendly times (such as "an hour ago" for job submission time)
[ ] CoreUI comes with a login page (see minimal example at https://github.com/mrholek/CoreUI-Free-Bootstrap-Admin-Template/tree/master/Angular2_CLI_Full_Project). Use this for a mock login page.

masonlr commented 7 years ago

[x] Buttons overflow with some browser widths

masonlr commented 7 years ago

[x] saveJob() is using the newJobUrl (i.e. environment.apiUrl+"jobs"). Check whether saveJob() should instead be calling PUT on api/jobs/<job-id>.

    console.log("in save")
    let headers = new Headers({ 'Content-Type': 'application/json' });
    let options = new RequestOptions({ headers: headers });
    let response = this.http.patch(newJobUrl, jobData, options)
                    .catch(this.handleError);
    return response
  }

Okay as this.http.patch is used. I think that it is confusing to have newJobUrl as a variable name if the URL is serving multiple purposes. Renaming to jobsUrl may be less confusing.

myyong commented 7 years ago

Okay as this.http.patch is used. I think that it is confusing to have newJobUrl as a variable name if the URL is serving multiple purposes. Renaming to jobsUrl may be less confusing.

Agreed, have changed this.

masonlr commented 6 years ago

Closing due to migration to ant.design.