alan-turing-institute / simulate-middleware

Simulate middleware service.
http://simulate.readthedocs.io
0 stars 0 forks source link

Openfoam test #20

Closed nbarlowATI closed 6 years ago

nbarlowATI commented 6 years ago

Working middleware for openfoam, includes output API endpoint, job_id as a UUID, all tests pass.

codecov-io commented 6 years ago

Codecov Report

Merging #20 into master will decrease coverage by 4.88%. The diff coverage is 69.1%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #20      +/-   ##
==========================================
- Coverage   85.93%   81.05%   -4.89%     
==========================================
  Files          24       26       +2     
  Lines         917     1103     +186     
==========================================
+ Hits          788      894     +106     
- Misses        129      209      +80
Impacted Files Coverage Δ
connection/constants.py 88.88% <100%> (+2.22%) :arrow_up:
tests/fixtures.py 100% <100%> (ø) :arrow_up:
tests/create_and_mint_case_using_stores.py 83.33% <100%> (+2.08%) :arrow_up:
tests/create_mint_store.py 100% <100%> (ø) :arrow_up:
tests/test_job_running.py 100% <100%> (ø) :arrow_up:
routes/__init__.py 100% <100%> (ø) :arrow_up:
tests/test_job_creation.py 100% <100%> (ø) :arrow_up:
tests/test_case_list.py 100% <100%> (ø) :arrow_up:
tests/decorators.py 78.26% <100%> (+13.97%) :arrow_up:
routes/case_routes.py 81.81% <100%> (ø) :arrow_up:
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c779293...054a033. Read the comment docs.

nbarlowATI commented 6 years ago

Hi @masonlr , did you purge your db and re-populate with the test data before trying this? This step is necessary because the schema has changed..
As far as I'm aware things should work at least as far as getting job output with the current openfoam_test branch of gateway_openfoam. I'll check all this out in a fresh clone though..

masonlr commented 6 years ago

Yep test data was purged. I think it was a matter of me having an incompatible set of submodules. I can confirm that this PR achieves the following:

masonlr commented 6 years ago

For reference, this is the combination I tested with:

alan-turing-institute/gateway-frontend@f104d537 alan-turing-institute/gateway-middleware@054a033 alan-turing-institute/gateway-job-manager-openfoam@8acb64b alan-turing-institute/gateway-simulator-openfoam@e372c7b

We are currently aiming to update merge the corresponding branches into master on their respective submodules. Then we will update the umbrella gateway repo.