search

alan-turing-institute / spc-hpc-pipeline

Azure batch pipeline for the SPC project
MIT License
2 stars 0 forks source link

Containers aren't deleted #15

Closed AoifeHughes closed 1 year ago

AoifeHughes commented 1 year ago

https://github.com/alan-turing-institute/spc-hpc-pipeline/blob/4207caa7b75ceb1250928c84c8bfe9bd1cc82dc1/spc-hpc-client.py#L506

Just needs blob_service_client.delete_container(input_container_name) added back - must have been lost at some point.

crangelsmith commented 1 year ago

But i don't think we want to delete the containers? that is where all the output simulated data will be stored.

AoifeHughes commented 1 year ago

I wasn't sure if the end plan was to move the data somewhere else?

crangelsmith commented 1 year ago

Maybe, but it would be a shame that the container gets deleted at the end of the job without having downloaded/moved it. I think is safer that we delete by hand if we feel we have to.

AoifeHughes commented 1 year ago

Makes sense - will remove the confusing print statement