alan-turing-institute / trustchain

Trustworthy decentralised PKI
https://alan-turing-institute.github.io/trustchain/
Apache License 2.0
11 stars 5 forks source link

102 refactor verifiable timestamp #105

Closed thobson88 closed 1 year ago

thobson88 commented 1 year ago

Addresses #102.

thobson88 commented 1 year ago

Unit tests all pass but I haven't run the integration tests yet.

sgreenbury commented 1 year ago

This looks great, nice one! I've tried the integration tests, a couple of fails:

It looks like the verifiable_timestamp.timestamp_commitment().hash() call is not producing the expected hash.

thobson88 commented 1 year ago

Would be good to address #104 in here too.

sgreenbury commented 1 year ago

Since #106 is merged and all tests pass, this is ready to merge.