search

alan-turing-institute / trustchain

Trustworthy decentralised PKI
https://alan-turing-institute.github.io/trustchain/
Apache License 2.0
11 stars 5 forks source link

104 filter timestamp commitment #106

Closed thobson88 closed 1 year ago

thobson88 commented 1 year ago

Addresses #104.

It includes the filtering and I've added a couple of tests to make sure it works ok.

Also the verifiable_timestamp() method in IONVerifier is a bit simpler because the hasher and decoder are now free functions and baked in to the BlockTimestampCommitment.

But the new TimestampCommitment trait isn't ideal. Can we improve that?

sgreenbury commented 1 year ago

Fixed test and modified TrivialCommitment/Commitment (see comment). Looks good to me!