Currently there are some places in where config is being retrieved through calls such as ion_config(). This means library code depends on reading this config and makes unit testing more challenging.
Discussed solution:
Move IONConfig to the new() method for the IONVerifier
Add IONConfig as a field for CLIConfig and HTTPConfig so these have ION config available when constructing an IONVerifier
Remove ion_config() from the trustchain-ion crate replacing uses in the crate with &IONConfig in function signatures
Add a tests/ path to TRUSTCHAIN_DATA with all config required for running ignored tests that can be deserialized as required in the individual members of the workspace for tests.
Currently there are some places in where config is being retrieved through calls such as
ion_config(). This means library code depends on reading this config and makes unit testing more challenging.Discussed solution:
IONConfigto thenew()method for theIONVerifierIONConfigas a field forCLIConfigandHTTPConfigso these have ION config available when constructing anIONVerifierion_config()from thetrustchain-ioncrate replacing uses in the crate with&IONConfigin function signaturestests/path toTRUSTCHAIN_DATAwith all config required for running ignored tests that can be deserialized as required in the individual members of the workspace for tests.