search

alan-turing-institute / turing-commons

The main repository for the Turing Commons platform
MIT License
16 stars 5 forks source link

Removed Animations #53

Closed RichGriff closed 1 year ago

chrisdburr commented 1 year ago

Thanks, @RichGriff. I've merged and tested the new changes. Page rendering bug is no longer present, but some of the styles are no longer working as expected (e.g. light grey background of sections not filling full width of the page).

Screenshot 2023-06-21 at 14 40 33
RichGriff commented 1 year ago

Hey @chrisdburr

This is the same issue as why the animations were failing, as you'll notice, it's fine on initial load and page refresh, just not when navigating back.

This is because we had to use JavaScript to hide the element that was preventing the full width style. When I removed this on the overwrite template for main - it caused errors for your other pages, so we had to put in a workaround to only apply it to the homepage.

This is a weird caching behaviour with mkdocs. My recommendation is to use something other than mkdocs to render your markdown files. This could be done with something like Next.js.