Add the new BMI field. - Githubissues

alan-turing-institute / uatk-spc

Synthetic Population Catalyst

https://alan-turing-institute.github.io/uatk-spc/

MIT License

20 stars 12 forks source link

Add the new BMI field. #38

Closed dabreegster closed 2 years ago

dabreegster commented 2 years ago

non-breaking schema change, no new version needed
renamed input file
[X] I am regenerating the output data for all areas now...
[X] Rerun data/generate_manifest.sh, since input filenames changed from tus_hse to pop
[x] Run scripts/upload_data.sh
[x] Copy the new protobuf schema to the ASPICS repo as well

dabreegster commented 2 years ago

Also tagging @darribas to review. Ideally we wind up in a situation where more people can plumb through new fields through SPC and have some understanding of how to make the code changes

dabreegster commented 2 years ago

Also @mfbenitezp, you renamed the Bristol county area and added a few areas in https://github.com/alan-turing-institute/uatk-spc/commit/57ce25fdb4cb464626e1391a5d51ab17d0191138. When I regenerate, we're going to wind up with an output file for everything in config, named that way. Is that alright? Any reason to use the previous naming for Bristol or exclude the new areas?