Closed sgreenbury closed 5 months ago
Check out this pull request on
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
Hi Sam, @Hussein-Mahfouz would like to use this; need a beta tester?
That would be great, thanks! @Hussein-Mahfouz the python/README.md
is the best place to start but happy to discuss if unclear at all. Just to flag the API will change while this PR is in draft and the remaining features at the top are added.
Any comments on the usability/missing features would be very helpful!
Hi @sgreenbury ! I'm trying the SPC toolkit python package now, but having a small issue (I haven't used poetry before).
poetry install
but I get the following error
Poetry could not find a pyproject.toml file in /home/hussein/Documents/GitHub/uatk-spc or its parents
Hi @Hussein-Mahfouz, thanks for trying this out! Currently the instructions in the README assume you are on the branch associated with this PR (55-output-formats-python
) and are in the the python/
directory (where the README and pyproject.toml
are), apologies that wasn't clear. From the repo root if you try:
git checkout 55-output-formats-python
cd python
then poetry install
should work as you will now have the pyproject.toml
and package.
Removed upper limit on required python version (ad1d826, see https://github.com/Urban-Analytics-Technology-Platform/acbm/issues/10).
Thanks @dabreegster!
Closes #55.
Remaining tasks:
dev
andexamples
groups#[derive(Serialize)
on types no longer requiring serializenssec8
)Reader
andBuilder
classes--output-formats Vec<OutputFormat>