alan-turing-institute / uatk-spc

Synthetic Population Catalyst
https://alan-turing-institute.github.io/uatk-spc/
MIT License
21 stars 12 forks source link

SPC toolkit python package #67

Closed sgreenbury closed 5 months ago

sgreenbury commented 1 year ago

Closes #55.

Remaining tasks:

review-notebook-app[bot] commented 1 year ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

dabreegster commented 1 year ago

Hi Sam, @Hussein-Mahfouz would like to use this; need a beta tester?

sgreenbury commented 1 year ago

That would be great, thanks! @Hussein-Mahfouz the python/README.md is the best place to start but happy to discuss if unclear at all. Just to flag the API will change while this PR is in draft and the remaining features at the top are added.

Any comments on the usability/missing features would be very helpful!

Hussein-Mahfouz commented 1 year ago

Hi @sgreenbury ! I'm trying the SPC toolkit python package now, but having a small issue (I haven't used poetry before).

Poetry could not find a pyproject.toml file in /home/hussein/Documents/GitHub/uatk-spc or its parents

sgreenbury commented 1 year ago

Hi @Hussein-Mahfouz, thanks for trying this out! Currently the instructions in the README assume you are on the branch associated with this PR (55-output-formats-python) and are in the the python/ directory (where the README and pyproject.toml are), apologies that wasn't clear. From the repo root if you try:

git checkout 55-output-formats-python
cd python

then poetry install should work as you will now have the pyproject.toml and package.

sgreenbury commented 8 months ago

Removed upper limit on required python version (ad1d826, see https://github.com/Urban-Analytics-Technology-Platform/acbm/issues/10).

sgreenbury commented 5 months ago

Thanks @dabreegster!