alan-turing-institute / urbanroute

Urban routing algorithms
MIT License
2 stars 1 forks source link

Ellipses #14

Closed JamesCraster closed 4 years ago

JamesCraster commented 4 years ago

This PR adds matching of source and target vertices to the networkx graph, uses the elliptical bounding box method to limit the graph size, and applies dijkstra's algorithm to produce the shortest path between the source and target.

Type of change

Additional dependencies

Tests

How has the code been tested?

Issues fixes

List any issues this closes:

Checklist

Please ensure you have done the following:

Reviewer

PatrickOHara commented 4 years ago

If source_lat == target_lat will this break due to divide by 0?

Add a quick test.

JamesCraster commented 4 years ago

If source_lat == target_lat will this break due to divide by 0?

Add a quick test.

This occurs if source_long = target_long, in which case it should be that theta = pi/2