Feature/18 pipeline - Githubissues

alan-turing-institute / vivarium_population_spenser

Vivarium microsimulation tools used to model population evolution with the SPENSER project

GNU General Public License v3.0

3 stars 0 forks source link

Feature/18 pipeline #22

Closed kasra-hosseini closed 4 years ago

kasra-hosseini commented 4 years ago

Notebook to run our pipeline using [TestPopulation(), Mortality()] components; plot the results
Read inputs from a config file
Add requirements.txt file

crangelsmith commented 4 years ago

Hi @kasra-hosseini , thanks for this! As you can see in PR #23 the fertility module is basically ready. One thing that I changed is that i made the rate transformation function more general and changed its name, once we merge we need to make sure to propagate that change to the notebooks (should be straight forward).

Should we continue implementing the fertility module in this PR or do you think we should start a new one?

kasra-hosseini commented 4 years ago

Hi @crangelsmith , Thanks for the PR #23 and for the comments. Maybe it is better to start a new PR for fertility. The first two notebooks can be left as they are, and in the next PR: 1) adapt the notebooks (1 and 2) according to the new changes (i.e., the rate transformation function) 2) add the fertility component. How does it sound?

kasra-hosseini commented 4 years ago

In fact, I can adapt the notebooks / add a new notebook for fertility in PR #23 before merge.