alan-turing-institute / whatwhat

A reimagining of nowwhat in OCaml
MIT License
0 stars 0 forks source link

Don't complain about finance codes when GitHub metadata cannot be parsed #112

Open yongrenjie opened 6 months ago

yongrenjie commented 6 months ago

https://github.com/alan-turing-institute/whatwhat/blob/41b775525edf72ada6610f14d1090073ef7ee6b4/lib/schedule.ml#L368-L374

If gh_p.plan is None then the entirety of github metadata failed to parse, meaning that info about project codes on github has been discarded. So we should not issue an error here. The error should only occur if both forecast and github data could be parsed into Some x and they were found to not match.

(The fact that github metadata failed to parse will have been reported as a different error, something like E20xx.)