alan-turing-institute / whatwhat

A reimagining of nowwhat in OCaml
MIT License
0 stars 0 forks source link

move metadata validation to github.ml #20

Closed callummole closed 2 years ago

callummole commented 2 years ago

This PR attempts to separate 'obtaining the data' (GithubRaw) and 'validation' (Github).

Currently I have just managed to move the metadata code across to the new file github.ml.

This need some thought - the current design is rather ugly. For example, I have separated a GithubRaw.Issue and a Github.Project, which have mostly the same fields but the Github.Project has the metadata parsed (the idea was that Issue is Github speak, but for Nowwhat a project is an issue but with some key metadata). Also, the code runs more slowly because it there is now the additional step of looping through the entire issue list after navigating the query body.