search

alan-turing-institute / whatwhat

A reimagining of nowwhat in OCaml
MIT License
0 stars 0 forks source link

Factor out all hard-coded config data #38

Closed triangle-man closed 1 year ago

triangle-man commented 1 year ago

There are a few places where "configuration" data is hard-coded: for example, in the names of GitHub Projects, or the Columns that should be investigated.

At the very least, it would be good to have these collected at the top of the module they're defined in; better would be to have them in the Config module, or in a config file somewhere.

mhauru commented 1 year ago

Cases I could think of have now been moved to ~/.config/nowwhat/config.json, from where the Config module parses them. Could be good to still go through the code and check that there aren't other bits that should be moved there.

yongrenjie commented 1 year ago

This should be complete in 251758d