Add assignees and emojis when merging projects from GitHub and Forecast

alan-turing-institute / whatwhat

A reimagining of nowwhat in OCaml

MIT License

0 stars 0 forks source link

Add assignees and emojis when merging projects from GitHub and Forecast #51

Closed triangle-man closed 1 year ago

triangle-man commented 1 year ago

Schedule is responsible for merging projects from Forecast and GitHub. At the moment, it just checks that a Forecast project has a matching GitHub issue.

triangle-man commented 1 year ago

The comment for merge_projects is

(* Check that each Forecast project has a hut23 code which matches that of a
   Github project

   In addition, this function should (but currently does not)
   - check that the "Client" on Forecast is the same as the "Programme" on GitHub
   - (maybe) check that the name is identical
   - replace the people in "assignees" and "emojis" with the matching person from Forecast

   TODO: This is O(N^2). Tut tut. 
 *)

mhauru commented 1 year ago

TODO: This is O(N^2). Tut tut.

I think we can make this O(N) with some Maps/hash tables.

yongrenjie commented 1 year ago

Assignees are now fetched and parsed
Emojis aren't fetched by default (because it requires an additional API call), but can be fetched separately at point of use. We do do this at several points in the code!
merge_projects is O(N lg N) since https://github.com/alan-turing-institute/whatwhat/commit/e2c01012f85c5a039f723ecf7994a7c2641bd146 😊 (Not the most atomic commit, I'm aware, haha.)