Results of merging Forecast and GitHub data seem... odd.

[yongrenjie]

Working on the dev branch:

• Schedule.get_the_schedule only returns 15 assignments, which seems slightly low (note that Forecast.get_the_schedule fetches around 500+ assignments, so it's likely something going on with merging the two sources of data)
• Some of those 15 assignments have the finance code "GitHub: NNN" where NNN is actually the issue number, or "Applied Skills". This probably comes from picking the first label in Forecast (instead of looking for one that is actually a project code). We could try to 'cleverly' detect which label is the finance code, but a possibly better idea would be to get the finance code from the GitHub issue YAML, and then check that Forecast has a label corresponding to that.
• Allocation durations reported are negative, because sub d1 d2 actually means d1 - d2, not d2 - d1:

https://github.com/alan-turing-institute/whatwhat/blob/82113da23cf0936f6bc40d9d7b10bacc3b64e418/lib/forecast.ml#L164

• Possibly other weird issues yet to be discovered.

[yongrenjie]

Ok, this is because of invalid YAML metadata, so active projects are being removed entirely from the programme. Specifically, the project tracker contains 34 issues in the AGNG, FP, AS, and Active columns (as of the time of writing), of which:

• 7 have unreadable YAML (332, 536, 428, 607, 768, 400, 96);
• 18 have incomplete metadata (1278, 1204, 1250, 1226, 1052, 1175, 1241, 1214, 1217, 1216, 1205, 1279, 1056, 953, 969, 1049, 593, 1304). The majority of these are missing a project code.

That leaves 9 issues that have readable and complete YAML (1185, 1234, 1066, 1132, 1077, 1095 1079, 1096, 482). Only assignments belonging to these issues are retained, so only fetching 15 assignments makes sense.

I guess we should save the warnings until the end instead of simply deleting the issues at such at early stage. Even if a project is missing a code we'd probably still like to track allocations and FTEs, while also bugging people to edit in a project code.

[yongrenjie]

The finance code is optional now, I think. (see e.g. 1214) However, other errors in the metadata still lead to projects being deleted (see e.g. 1216). This is a bit annoying, and not difficult to fix, but will probably be tedious (I think).

[yongrenjie]

Fixed the above. Now whatwhat reports that it got:

44 people (correct as of the time of writing); 31 projects (correct as of the time of writing); and 118 assignments (I didn't go to Forecast to count, but this seems like a sensible number).