alandarev / wowmod

WoW mod for Counter-Strike:Source
GNU General Public License v3.0
13 stars 8 forks source link

Compiler #13

Open pkminer30 opened 8 years ago

pkminer30 commented 8 years ago

Unable to compile on latest sourcemod.

Give 16 errors:

https://gyazo.com/8113169e30665b824272e39f007b1de1

Sorry about the ghosted text (it auto closes on complete)

How to fix?

alandarev commented 8 years ago

These errors arrived with the changes done to new compiler.

It means, you have two options:

  1. Use older compiler for this project. A 1-2 year old, too old compilers won't work as well :)
  2. Modify the code to fix those deprecation warnings and errors. There actually aren't many modifications to carry out, and as I remember someone did, but never submitted the push request.
goodtime753 commented 7 years ago

I tried the old version of SM - did not help Help assemble plugin correctly

aloifolia commented 7 years ago

I ran into the same problems. It would really be nice if someone who is able to could fix these problems.

upidstupid commented 7 years ago

I started taking a look at this- I've gotten through fixing errors and have local server w/ mod running.

Next is fixing warnings and testing.

However, I have had to remove a dependency on cssdm- I could not get it to run properly.

upidstupid commented 7 years ago

I have proposed fixes on branch masterCompilerFixes. These fixes are against the latest versions of SM and MM (sourcemod-1.8.0-git6025 and mmsource-1.10.7-git959, respectively).

I have done some basic testing- server starts up, goes through basics without crashing.

Before merging with master, it would be great if someone (aloifolia) could test it for more confidence.

Otherwise, in a few days I will pull it in, or someone else with permissions can.

I'll start looking at the csgo branch now.

aloifolia commented 7 years ago

Well, I would really like to test your changes. However, I have no clue how to compile the source code...

alandarev commented 7 years ago

@upidstupid feel free to merge it to master if it works. Afterall you are a collaborator. I appreciate everyone working on this mod, sadly I have little time to invest into it myself.

upidstupid commented 7 years ago

I'll merge after I get home from the weekend.

Spare time comes and goes for us all...

On Sep 1, 2017 3:17 AM, alandarev notifications@github.com wrote:

@upidstupidhttps://github.com/upidstupid feel free to merge it to master if it works. Afterall you are a collaborator. I appreciate everyone working on this mod, sadly I have little time to invest into it myself.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/alandarev/wowmod/issues/13#issuecomment-326545124, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ACIjbGBYtdM2uDEHwuNUJgiLFAr-0UE0ks5sd9megaJpZM4JD3UU.