search

alandefreitas / clang-unformat

A simple tool to infer a .clang-format file from existing code
Boost Software License 1.0
58 stars 13 forks source link

Required Boost version seems to high #10

Open verri opened 1 year ago

verri commented 1 year ago

First of all, congratulations for this great tool.

I was compiling in Ubuntu 22.04, which uses Boost 1.74 by default, and I realized that the current CMakeLists.txt requires boost 1.78.

I have changed the file to require version 1.74, and it compiled and executed fine.

verri commented 1 year ago

Also FetchContent is available only for CMake 3.11 or above.

alandefreitas commented 1 year ago

Yes. Updating the version requirements is always helpful. I didn't worry too much about looking for the minimal version that would work because this is only an application that can be compiled once so other libraries won't directly depend on it. Same for FetchContent, which could check the CMake version.

royshil commented 1 year ago

i was able to build with boost v1.74 and also removing boost-process from the required components

alandefreitas commented 1 year ago

Yes. That should work.