search

alandefreitas / matplotplusplus

Matplot++: A C++ Graphics Library for Data Visualization 📊🗾
https://alandefreitas.github.io/matplotplusplus/
MIT License
4.24k stars 325 forks source link

Fix spurious toolchain warning #263

Closed codeinred closed 2 years ago

codeinred commented 2 years ago

This commit fixes a spurious warning emitted by Matplot++ when building against Matplot++ using find_package. This warning is being emitted even when the compiler originally used to build Matplot++ is identical to the one being used to build against the Matplot++ package.

This warning occurs because the Matplot++ Cmake Config file compares the current compiler version to the Compiler used to build Matplot++. This always fails, because the version (eg, 11.2.0) is always different from the Compiler ID (In my case, GNU).

The warning was fixed by instead comparing the current Compiler ID to the ID of the compiler used to build Matplot++ (so now if it was built with GNU, and a consumer compiles against it with GNU, there's no warning).

Below is an image of the warning message. Note that the current compiler is also GNU.

image

alandefreitas commented 2 years ago

Wow... this is a serious problem.

Thanks again, @codeinred !

codeinred commented 2 years ago

Happy to contribute! It’s a good library!