search

alandefreitas / matplotplusplus

Matplot++: A C++ Graphics Library for Data Visualization 📊🗾
https://alandefreitas.github.io/matplotplusplus/
MIT License
4.1k stars 311 forks source link

fix: install matplot_opengl in CMake #337

Closed aminya closed 1 year ago

aminya commented 1 year ago

Fixes the missing matplot_opengl install

alandefreitas commented 1 year ago

This target is very experimental and missing almost all features. I didn't think anyone wanted that installed.

In any case, I believe it would still need to find the dependencies in the cmake config file to work properly.

aminya commented 1 year ago

The installation only happens when the experimental option is enabled. Otherwise, it will not be installed

alandefreitas commented 1 year ago

The installation only happens when the experimental option is enabled. Otherwise, it will not be installed

Yes. That's fine.

Have you tried using what it installs locally? Did it work? I would expect a few find_dependency in the config template for that to work.

aminya commented 1 year ago

Yes, I tested it. It actually works with vcpkg as well as the platforms they test: https://github.com/microsoft/vcpkg/pull/31229

alandefreitas commented 1 year ago

Thanks! :)