Doesn't work on Julia 1.1?

NOTtheMessiah commented 5 years ago

Tried installing and running on the latest release of Julia. I'm on Linux if that is relevant:

(v1.1) pkg> add https://github.com/alanderos91/biosimulator.jl.git
   Cloning git-repo `https://github.com/alanderos91/biosimulator.jl.git`
  Updating git-repo `https://github.com/alanderos91/biosimulator.jl.git`
[ Info: Assigning UUID 72814a49-3568-55f0-8488-74f6d7e2ef26 to biosimulator
 Resolving package versions...
 Installed Inflate ──────── v0.1.1
 Installed TikzGraphs ───── v1.0.1
 Installed Tables ───────── v0.1.17
 Installed StatsFuns ────── v0.8.0
 Installed LightGraphs ──── v1.2.0
 Installed DataFrames ───── v0.17.1
 Installed WeakRefStrings ─ v0.5.7
 Installed StatsBase ────── v0.28.1
 Installed LaTeXStrings ─── v1.0.3
 Installed StaticArrays ─── v0.10.3
 Installed ArnoldiMethod ── v0.0.4
 Installed MacroTools ───── v0.4.5
 Installed TikzPictures ─── v3.0.4
  Updating `~/.julia/environments/v1.1/Project.toml`
  [72814a49] + biosimulator v0.0.0 #master (https://github.com/alanderos91/biosimulator.jl.git)
  Updating `~/.julia/environments/v1.1/Manifest.toml`
  [ec485272] + ArnoldiMethod v0.0.4
  [9e28174c] + BinDeps v0.8.10
  [324d7699] + CategoricalArrays v0.5.2
  [944b1d66] + CodecZlib v0.5.1
  [a93c6f00] + DataFrames v0.17.1
  [9a8bc11e] + DataStreams v0.4.1
  [864edb3b] + DataStructures v0.15.0
  [d25df0c9] + Inflate v0.1.1
  [82899510] + IteratorInterfaceExtensions v0.1.1
  [b964fa9f] + LaTeXStrings v1.0.3
  [093fc24a] + LightGraphs v1.2.0
  [1914dd2f] + MacroTools v0.4.5
  [e1d29d7a] + Missings v0.4.0
  [bac558e1] + OrderedCollections v1.0.2
  [3cdcf5f2] + RecipesBase v0.6.0
  [ae029012] + Requires v0.5.2
  [79098fc4] + Rmath v0.5.0
  [699a6c99] + SimpleTraits v0.8.0
  [a2af1166] + SortingAlgorithms v0.3.1
  [276daf66] + SpecialFunctions v0.7.2
  [90137ffa] + StaticArrays v0.10.3
  [2913bbd2] + StatsBase v0.28.1
  [4c63d2b9] + StatsFuns v0.8.0
  [3783bdb8] + TableTraits v0.4.1
  [bd369af6] + Tables v0.1.17
  [b4f28e30] + TikzGraphs v1.0.1
  [37f6aa50] + TikzPictures v3.0.4
  [3bb67fe8] + TranscodingStreams v0.8.1
  [30578b45] + URIParser v0.4.0
  [ea10d353] + WeakRefStrings v0.5.7
  [72814a49] + biosimulator v0.0.0 #master (https://github.com/alanderos91/biosimulator.jl.git)
  [9fa8497b] + Future 

julia> using BioSimulator
ERROR: ArgumentError: Package BioSimulator not found in current path:

alanderos91 commented 5 years ago

Looks like this was installed as biosimulator. Try running using biosimulator to confirm. If that works, then simply reinstall by

(v1.1) pkg> rm biosimulator
(v1.1) pkg> add https://github.com/alanderos91/BioSimulator.jl.git

Note the capitalization.

In theory, everything should work on Julia 1.1 but this has not been verified (TravisCI suggets it's okay).

NOTtheMessiah commented 5 years ago

I think I figured it out, I need to run Pkg.add(PackageSpec(url="https://github.com/alanderos91/BioSimulator.jl",name="BioSimulator")) instead of simply using ] add https://github.com/alanderos91/biosimulator.jl.git or else it infers the name of the package from the URL.

using biosimulator won't work because it doesn't match the exported module name.

alanderos91 commented 5 years ago

Yes, that is equivalent to the installation instructions in the README. Note, however, that everything done in pkg mode ought to be equivalent to using Pkg explicitly. The line:

[72814a49] + biosimulator v0.0.0 #master (https://github.com/alanderos91/biosimulator.jl.git)

in your original post states that the package name is inferred as biosimulator. From what I tested locally, it seems that

(v1.1) pkg> add https://github.com/alanderos91/biosimulator.jl.git # install as biosimulator
(v1.1) pkg> add https://github.com/alanderos91/BioSimulator.jl.git # install as BioSimulator

works as intended.

I'll add some instructions for development purposes.

alanderos91 / BioSimulator.jl

Doesn't work on Julia 1.1? #17