search

alandoni / fifa-champs

1 stars 1 forks source link

Feature/hall of fame enhancements #116

Closed kiosia closed 6 years ago

kiosia commented 6 years ago

Here we go.

There is a lot going on, but it is basically new visuals for the hall of fame, as well as new stats and supporting functions.

xoxo

kiosia commented 6 years ago

Do not merge, I am refactoring some stuff

kiosia commented 6 years ago

@alandoni @aquintiliano (not sure which user you are using for reviews) and @cristiadu : all issues on the PR were solved! hope to see this in prod soon

Be aware that since there are some additions to the Championship data, an admin needs to go to every Championship standings to update its stats on the db. Only then, the new data will be shown on the "hall of fame" page.

There are still room for improvements, like only updating stats of championships that does not have stats and stuff like that. But I think that can be dealt with when the standings page functions are moved to the backend (please, create Issues as you see fit, I'm no PO).