search

alandtse / CommonLibF4

A reverse-engineered resource for Fallout 4
MIT License
6 stars 4 forks source link

refactor: various additions and changes #15

Closed qudix closed 1 year ago

qudix commented 1 year ago

As the dynamic runtime stuff isn't being used yet I've taken the opportunity to change some class names to be shorter, as well as making the feature macros be the same. There is also a new header called WinSTL which is a sort of standard library for c++ to WinAPI helper utilities.

Opinionated changes: RelocationID -> ID2 VariantOffset -> Offset2 VariantID -> gone for now, will likely come back in another form at a later date.

alandtse commented 1 year ago

I'm not sure I want to break compatibility with SSE NG. What is the issue we're fixing by removing those equivalent functions and having people learn another syntax? There's already a lack of people in FO4, making it harder doesn't seem prudent since the most likely cross pollination is from SSE. Can we just add a define to give you the new function names?

qudix commented 1 year ago

What do you mean compatibility? I'm also not sure what you mean by function names, do you mean classes?

alandtse commented 1 year ago

What do you mean compatibility? I'm also not sure what you mean by function names, do you mean classes?

RelocationID. You've removed that function name. People will now need to learn ID2. Yes it's easy, but it's unnecessary friction as someone still needs to try different things before it appears. You can add another duplicate function or DEFINE that also allows ID2, but don't remove the other one.

qudix commented 1 year ago

You're confusing me with calling them functions, but I get what you mean. How about I add aliases using the old names and mark them as deprecated? People can still use the old names but they'll get a message in the console to use the new one.

alandtse commented 1 year ago

That's fine. Yah, I code in too many languages so can't remember the specific terms sometimes. Class methods?

alandtse commented 1 year ago

I'm not sure why it's not giving an option to rebase, but can you make sure this is rebased on master please?

alandtse commented 1 year ago

Never mind. I manually pulled it in. Appears to compile so I'll merge.