IMenu functions returning incorrect flags

alandtse / CommonLibVR

This is an experimental reverse engineered library for Skyrim VR (ported from CommonLibSSE). There are two main branches (VR) which is based on po3's using ifdefs, and NG which is an updated NG build.

MIT License

19 stars 18 forks source link

IMenu functions returning incorrect flags #51

Closed AtomCrafty closed 2 days ago

AtomCrafty commented 2 weeks ago

The flag values returned by these functions don't match the respective function names, but are shuffled around. Probably not a big deal since those don't sound like the most commonly used functions, but that doesn't look intentional.

alandtse commented 2 weeks ago

Thanks. Feel free to submit a PR. It may make sense to do it in an upstream fork line po3s and we'll get the fix when we sync.

AtomCrafty commented 1 week ago

Done https://github.com/powerof3/CommonLibSSE/pull/109

alandtse commented 1 week ago

Awesome thanks. I'll see about syncing again with po3.

alandtse commented 1 week ago

Actually, let's leave it open until I've done the sync else I'll forget.

alandtse commented 2 days ago

This should be all in for VR/NG. Thanks!