search

alandtse / tesla

Tesla custom integration for Home Assistant. This requires a refresh token be generated by third-party apps to login.
Apache License 2.0
601 stars 99 forks source link

fix: Bump teslajsonpy to 3.12.2 #1067

Closed ehendrix23 closed 1 hour ago

ehendrix23 commented 3 days ago

Bump teslajsonpy to 3.12.2 which includes fix for API service

alandtse commented 3 days ago

Please review other bumps. Other files will also also need to be changed.

ehendrix23 commented 2 days ago

Updated the additional files. Not sure why the test would fail though as nothing there has been changed.

alandtse commented 2 days ago

Someone probably broke the test with a commit.

ehendrix23 commented 22 hours ago

Someone probably broke the test with a commit.

Found reason for both tests that failed:

  1. PR #1069 fixes the issue where in_progress returns True. This is because in_progress requires a boolean and not a number, update_percentage instead should be used for percentage.
  2. PR #479 in teslajsonpy fixes the issue when both a websession and a certificate is provided. This would then result in bump for teslajsonpy and hence will update this commit with new version once released.
alandtse commented 12 hours ago

Thanks for figuring that out. Is the other PR #1069 a prereq of this? Normally I'd want to keep the test fix as a separate PR so the bump PR is very clean.

ehendrix23 commented 1 hour ago

Thanks for figuring that out. Is the other PR #1069 a prereq of this? Normally I'd want to keep the test fix as a separate PR so the bump PR is very clean.

Nope, no dependencies. PR #1069 was purely to update for HA 2024.11 and had nothing to do with teslajsonpy. :-)

FYI, seems I screwed some things up so closing this PR for the bump and creating a new one instead that is clean. :-)