search

alanedwardes / VAwesomium

Awesomium implementation for Valve's Source Engine, as a UI element.
5 stars 3 forks source link

Multiple Webviews #2

Closed beerendlauwers closed 11 years ago

beerendlauwers commented 11 years ago

The code in its current state will cause crashes when trying to create more than one VAwesomium panel. This patch addresses that.

alanedwardes commented 11 years ago

@BeerendLauwers thanks for the contribution! Would you like to be added as a contributor on here, so you can submit any future code to this repository without using pull requests?

I've since moved to the 2013 SDK which has native WebKit support, and it's a bit difficult for me to bring up 2007 to test with for future requests. If you're still actively working with that code base it may be a good idea.

beerendlauwers commented 11 years ago

Hey Alan, thanks for the offer. I'll probably do a few more modifications, but after that, we probably won't have much more to add. Unfortunately, we can't switch to the 2013 SDK with our mod (Empires Mod), because the code is waaay too modified and spaghetti-like (we can thank the original developer for that). Hence, our interest in the vanilla Awesomium library.

I was wondering if it would be possible to extract the Webkit support from the 2013 SDK and put it in Source 2007; would this be madness or just a lot of work? Anything you've seen that would prohibit this?

Sincerely, Beerend Lauwers

On Thu, Aug 29, 2013 at 6:35 PM, Alan Edwardes notifications@github.comwrote:

@BeerendLauwers https://github.com/BeerendLauwers thanks for the contribution! Would you like to be added as a contributor on here, so you can submit any future code to this repository without using pull requests?

I've since moved to the 2013 SDK which has native WebKit support, and it's a bit difficult for me to bring up 2007 to test with for future requests. If you're still actively working with that code base it may be a good idea.

— Reply to this email directly or view it on GitHubhttps://github.com/alanedwardes/VAwesomium/pull/2#issuecomment-23503587 .

alanedwardes commented 11 years ago

That sucks, really sorry you're having to deal with that.

Looking at the files we do seem to have the source of the WebKit implementation: https://github.com/ValveSoftware/source-sdk-2013/tree/master/sp/src/vgui2/chromehtml / https://github.com/ValveSoftware/source-sdk-2013/blob/master/sp/src/vgui2/vgui_controls/HTML.cpp

I have no idea how difficult it would be to port it though. It looks like it should be possible. You'll need to link up some third party libs like protocol buffers (it uses that for it's cross-thread comms) and chromium embedded framework. (In the 2013 source they seem to have included the former but not the latter).

beerendlauwers commented 11 years ago

This looks pretty nice, we can probably find out what version of CEF they're using and perhaps we can port this over. Thanks for the help!

On Fri, Aug 30, 2013 at 12:47 PM, Alan Edwardes notifications@github.comwrote:

That sucks, really sorry you're having to deal with that.

Looking at the files we do seem to have the source of the WebKit implementation: https://github.com/ValveSoftware/source-sdk-2013/tree/master/sp/src/vgui2/chromehtml/ https://github.com/ValveSoftware/source-sdk-2013/blob/master/sp/src/vgui2/vgui_controls/HTML.cpp

I have no idea how difficult it would be to port it though. It looks like it should be possible. You'll need to link up some third party libs like protocol buffers (it uses that for it's cross-thread comms) and chromium embedded framework. (In the 2013 source they seem to have included the former but not the latter).

— Reply to this email directly or view it on GitHubhttps://github.com/alanedwardes/VAwesomium/pull/2#issuecomment-23553551 .

beerendlauwers commented 11 years ago

Hey Alan, we tried to port over the CEF framework from the 2013 sdk, but we'll probably need to expose CEF ourselves, as in the 2013 sdk it goes via the ISurface interface. No idea if the performance will be impacted. We'll move on with Awesomium for the moment. I'm going to post some benchmarks on the Valve wiki later on. Op 30 aug. 2013 14:25 schreef "Beerend Lauwers" beerendlauwers@gmail.com het volgende:

This looks pretty nice, we can probably find out what version of CEF they're using and perhaps we can port this over. Thanks for the help!

On Fri, Aug 30, 2013 at 12:47 PM, Alan Edwardes notifications@github.comwrote:

That sucks, really sorry you're having to deal with that.

Looking at the files we do seem to have the source of the WebKit implementation: https://github.com/ValveSoftware/source-sdk-2013/tree/master/sp/src/vgui2/chromehtml/ https://github.com/ValveSoftware/source-sdk-2013/blob/master/sp/src/vgui2/vgui_controls/HTML.cpp

I have no idea how difficult it would be to port it though. It looks like it should be possible. You'll need to link up some third party libs like protocol buffers (it uses that for it's cross-thread comms) and chromium embedded framework. (In the 2013 source they seem to have included the former but not the latter).

— Reply to this email directly or view it on GitHubhttps://github.com/alanedwardes/VAwesomium/pull/2#issuecomment-23553551 .

alanedwardes commented 11 years ago

Ah, right. Yeah the old IE stuff goes through surface too doesn't it? Shame we don't have that code.

Cool. If I can help you out let me know.