search

alangecker / bigbluebutton-docker

merged into https://github.com/bigbluebutton/docker
GNU Lesser General Public License v3.0
99 stars 33 forks source link

Add recording feature #16

Closed artemtech closed 4 years ago

artemtech commented 4 years ago

Video recording is working, but not for audio yet :(

edit by @alangecker: closes #4

alangecker commented 4 years ago

seems like quite some effort so far. thanks a lot!

a goal of this project was to avoid having a monolithic container but rather using dockers benefits and splitting the functionality in different containers, which are easier maintainable and more stable.

The path of reaching this goal was to start with the "official" approach (bigbluebutton/docker) which I called core and isolating step by step parts into there own containers. The idea was that at the end™ the core container is gone, because all its components are extracted and clearly separated. This MR now, for the first time, adds components again to core which for me personally doesn't feel reasonable since it would mean a step away from this design concept.

Also there are quite a lot of people who are using BBB intentionally without the recording functionality because of privacy concerns (https://github.com/bigbluebutton/bigbluebutton/issues/9202). A separate recording container would also provide an easy way for running it optionally.

Can you imagine moving the feature into an own container?

During the next two weeks I will be quite busy, but after that I can also help with that task if you don't feel motivated! ;)

artemtech commented 4 years ago

oh ok, i'll give it a try to separate recording container,

alangecker commented 4 years ago

I've managed to get audio recording! :)

currently freeswitch's mod_opusfile in the official freeswitch debian repository can't create a file. there is an open pull request fixing it, but not merged yet: https://github.com/signalwire/freeswitch/pull/719

I now replaced it with the binary from the official bigbluebutton repo and added the libopusenc0 dependency.

additionally:

I did already some work with separating the recording stuff into its own container, I will hopefully finish that in the next days ;)

alangecker commented 4 years ago

so, now in a working state with an own container. feel free to review it! :)

open tasks

alangecker commented 4 years ago

so, everything is done from my perspective. Would be anyone up for doing a review? maybe @artemtech? :)

alangecker commented 4 years ago

I'm not really sure how/why I apparently closed this PR?^^

congthang1 commented 4 years ago

Is this working? Lol

artemtech commented 4 years ago

i have tested it and works well in my setup.

staukini commented 4 years ago

Nice work @artemtech and @alangecker !

Thanks a lot - can't wait for a merge to the main branch.

senatoregiorgio commented 4 years ago

Thank you very much for implementing this feature! 🙂

When are you going to merge this pull request to the master branch? 🚀

alangecker commented 4 years ago

It is finally so far! :tada:

(will be included in the main v2.2.x branch with the Release v2.2.23-1)

alangecker commented 4 years ago

argh @artemtech i've just seen (after merging) that you later added some changes which aren't related to that recording feature. I'll revert them again for the Release v2.2.23-1, but feel free to open new Pull Requests for them! :)