search

alangecker / bigbluebutton-docker

merged into https://github.com/bigbluebutton/docker
GNU Lesser General Public License v3.0
98 stars 33 forks source link

expose more BBB settings in .env file #34

Closed cjhille closed 4 years ago

cjhille commented 4 years ago

closes #22

alangecker commented 4 years ago

deleting all the .wav files effects much more than just the known announcements in the html5 client. It results, for example, in silence on SIP dial in. I think the prefered way is to simply configure freeswitch in the right way. I archived that with a template.

Additionally I renamed some variables to more understandable names and added default values, so that a existing setup doesn't break on upgrade, when the variables are missing.

now, everything seems fine! :)

thanks for your contribution!

cjhille commented 4 years ago

Oh right.. I totally forgot the existing setups that need to be upgraded. And regarding the freeswitch config: I tried, but ultimately failed to find a working configuration. Thank you for fixing this and integrating it the proper way :)

Just FYI: The variable names I used were quite awkward and the ones you picked are a lot more decisive (e.g. "SKIP_CHECK" vs "DISABLE_ECHO_TEST"). But I initially chose to stick with the BBB-naming for those properties, so that users can easily find the the corresponding lines within the docs or discussion boards. I suppose giving the more meaningful names might alleviate the need for the latter ^^

alangecker commented 4 years ago

Just FYI: The variable names I used were quite awkward and the ones you picked are a lot more decisive (e.g. "SKIP_CHECK" vs "DISABLE_ECHO_TEST"). But I initially chose to stick with the BBB-naming for those properties, so that users can easily find the the corresponding lines within the docs or discussion boards. I suppose giving the more meaningful names might alleviate the need for the latter ^^

ah, good point! maybe we could simply add the "official" BBB-names to the comments in sample.env?

cjhille commented 4 years ago

good idea, maybe something like [...], refers to / translates to config flag: SKIP_CHECK