Closed trickert76 closed 3 years ago
I think, your project is a much better approach to dockerize BBB or wait for a new BBB version that supports Ubuntu 18.04 or 20.04.
thanks a lot for appreciating it!
I think, the way, you integrate the optional nginx and coturn isn't ideal. I think, it would be "nicer" to have only the docker-compose.yml and (which is supported out of the box from docker-compose) an additional docker-compose.override.yml
hmm, I don't really understand the disadvantages of the current solution? :D
I personally think it is "nicer" like it is now, but with that we are so far just expressing our taste^^
setup
run), since we aren't able to set them in the compose
script anymore.I've two disadventages for you:
As an adventage
I'll make a proposal. I'm not sure, if I can do that this week, but I try.
Can you have a look at: https://github.com/trickert76/bigbluebutton-docker
Of course it doesn't contain your latest changes (ipv6, prometheus).
sed
and tr
)I would second this design change.
Coming from the docker environment it feels a bit hacky. You could still use a setup script, where you generate the .env file (including passwords) and generate one clean docker-compose.override.yml file.
I think with this step you could easily upload your bbb containers to docker hub where a bigger audience will notice this project.
Of course. I‘m not sure, why the images arent hosted on Docker Hub. But maybe with the new abilities here on Github (Actions and Hub) this could be easier. I‘d like to try that in my repo and give some feedback.
@trickert76 thanks a lot for your push in that direction!
As I wrote in https://github.com/alangecker/bigbluebutton-docker/pull/47#issuecomment-687743566 already, I think we should include this in the upcoming v2.3 release, so that these breaking changes are introduced in a moment where people are aware about it. This gives us the opportunity to even further completely rethink the way the tooling is done. Unfortunately this would abandon the work you've done already :/
./scripts/setup
./conf/config
file which is Tcl compatible so that it can be used as source ./conf/config
(current .env
has some syntax issues)../scripts/generate
./scripts/generate
docker-compose.yml
only based on ./conf/config
and a docker-compose.yml.tmpl
cat
and sed
commands can.docker run jwilder/dockerize
to avoid any new dependencies on the host.would be happy about any feedback! :)
As someone who is used to docker and docker-compose, I fully agree with the points made by @trickert76; the current design is both unidiomatic and more complex than necessary. Thank you for your work :)
I worked now on a new approach: https://github.com/alangecker/bigbluebutton-docker/pull/71 @clawoflight maybe you have some feedback on that? :)
this is now finally done in the v2.3.x
branch! :)
see https://github.com/alangecker/bigbluebutton-docker/pull/71#issuecomment-777506431
I think, your project is a much better approach to dockerize BBB or wait for a new BBB version that supports Ubuntu 18.04 or 20.04.
I think, the way, you integrate the optional nginx and coturn isn't ideal. I think, it would be "nicer" to have only the docker-compose.yml and (which is supported out of the box from docker-compose) an additional docker-compose.override.yml (see https://devilbox.readthedocs.io/en/latest/configuration-files/docker-compose-override-yml.html).
I would change the setup script in a way, that it cats/echos/pipes the content of the docker-compose.*.yml into the docker-compose.override.yml, when the user says 'y' in the script. So, instead of
do a:
In that case a user can just use
docker-compose
in the root directory of the project.After reviewing the code, there are several other things to do:
compose
looks for the webhooks but that is only enabled manually.I'm switching (personally) to a Jinja template together with Ansible. That works too (because the script cannot be used easy in Ansible because of the question-answer-format without params).