search

alangecker / bigbluebutton-docker

merged into https://github.com/bigbluebutton/docker
GNU Lesser General Public License v3.0
99 stars 33 forks source link

Replace script/compose with docker-compose #47

Closed trickert76 closed 3 years ago

trickert76 commented 4 years ago

As mentioned in #42 there is the option to use docker-compose as it is. Because you already use a lot of environment variable, all of them can be stored in the .env file and a docker-compose.override.yml can be created.

The main adventage is, that a user can normally call docker-compose as it is and can use bash completion etc.

alangecker commented 4 years ago

sorry, for my unresponsiveness! :/ I'm currently quite busy with other work why my participation regarding BBB is currently reduced to a minimum... I will come back on this soon!

mooomooo commented 4 years ago

Did you forget to include conf/setup/docker-compose.init.yml in the commit? I can't seem to find it.

(Also, +1 for this approach)

trickert76 commented 4 years ago

You're right. My problem is, that I've switched to another workstation and the old one is reinitialized. I though - everything is checked in... I can't find the file.

But I think, it should only contain two lines (version+service) as some kind of header. I'l try to add it tomorrow. Also I can remove on the conflicts.

alangecker commented 4 years ago

heyho :)

  1. meanwhile I also support to this!
  2. Since this is a breaking change for most installations and v2.3 is upcoming anyway, I think we should release this with v2.3 so people are aware of the point when there are changes to their setup required, so that a ./scripts/upgrade within v2.2 doesn't break anything.
    • I switched the target branch to v2.3.x
    • Unfortunately some rebasing effort might me necessary
  3. If we already do a big change: cat-ing files can't be the best option possible... :D Isn't there any templating engine which supports conditional blocks without much dependencies? we even could use something like jinja2docker during the setup.
alangecker commented 3 years ago

the approach from https://github.com/alangecker/bigbluebutton-docker/pull/71#issuecomment-777506431 is now merged, so I consider this PR now as obsolete.

thanks for the impulsions @trickert76 ! :)