search

alangecker / bigbluebutton-docker

merged into https://github.com/bigbluebutton/docker
GNU Lesser General Public License v3.0
99 stars 33 forks source link

integration with nginx (docs) #88

Open xpbe0 opened 3 years ago

xpbe0 commented 3 years ago

https://github.com/alangecker/bigbluebutton-docker/issues/87

Hola Alan, I troubleshooted the complete universe (endless hours) just to return to initial very simple nginx configuration. Perhaps may help others too..

Thanks a lot 👍 🍻 -Pete

alangecker commented 3 years ago

thanks for the pull request! ...and sorry, that it took so long that I manage to review it 😅

just two tiny points:

  1. Add the following directives to the https virtual host bbb.example.com this might be quite unclear to a lot of people what that means. Maybe rather explain to edit/create a file under /etc/nginx/sites-enabled?
  2. you enabled the cache. I'm not sure how the nginx cache works, but without having it specified further, wouldn't that mean that it caches every path including for example the BigBlueButton API - making it sometimes not working anymore? If yes, I think this should be disabled in this place and at some point rather added for specific locations in the nginx container (https://github.com/alangecker/bigbluebutton-docker/tree/v2.2.x/mod/nginx/bbb)
xpbe0 commented 3 years ago

Hello Alan, thanks for your remarks. I removed cache from nginx config for now and elaborated a bit on your other point.