Closed Ebonsignori closed 1 year ago
Amazing work, thank you so much!! This is now live in v1.3.0.
Thank you especially for your help with the linting. I am not a developer by trade so there is a lot I don't know about the software developing process. I do use JS Standard style, and I left your eslint as you had it, as it seems like it works well to me š
Gotta start by saying I love this plugin and use it daily for journaling and mentioned it in my journaling plugin (pending review to community plugins)
Changes
This PR renamed "Other settings" to Date settings and added some features for more flexible date filtering
I really only wanted to load the day's dates from frontmatter since Auto Journal supports replacing a token, I set the
date
frontmatter key in my frontmatter for each journal entry and since I'm often backfilling a journal entry from the day before I wanted the Google Photos filter to open for that day.Ended up adding other logical choices for parsing the date and figured I'd tackle https://github.com/alangrainger/obsidian-google-photos/issues/14 while I was on a roll š
Closes https://github.com/alangrainger/obsidian-google-photos/issues/14
Linting ?
Just a suggestion you can push to this PR to remove, but I think you should add/enforce some sort of linting for this project. My projects and editor is setup to use prettier by default. It looks like your style might be closer to standard since you don't use semicolons.
I tried to add some custom eslint rules to
.eslintrc
to reflect your style. You can runnpm run lint:fix
to automatically apply them if you like them or extend the config as you see fit. Either way, it's nice as a contributor to be able to runnpm run lint:fix
because I automatically had prettier fix a few files I was touching and had to manually go through and undo some of the formatting š@alangrainger feel free to push to / change / merge this at will. It's your repo, I won't be offended