search

alangrainger / obsidian-google-photos

Connect to Google Photos from Obsidian
GNU General Public License v3.0
93 stars 5 forks source link

Suggestion: Embed remote images instead of downloading a local thumbnail #6

Closed khanhtoan529 closed 1 year ago

khanhtoan529 commented 1 year ago

It would be great if image could be embedded by using an image link. Some people (including me) don't want to add more images to the attachments folder if it is not neccessary.

Another way I think is to upload thumbnails to the image hosting service (https://github.com/gavvvr/obsidian-imgur-plugin). What do you think?

khanhtoan529 commented 1 year ago

Ah, I get the reason why you have to download local thumbnails at #4. But I think uploading thumbnails to the image hosting service will help a lot.

alangrainger commented 1 year ago

Adding the entire Imgur integration into this repo would definitely be out of scope and add a bunch of bloat. However it might be a very simple solution to have an option for the Google Photos plugin to paste the image data rather than saving a file - and then the existing Imgur plugin might automatically pick that up.

Do you want to clone the repo and try adding that? If it works, make a pull request and I'll add that in 👍

Myself I would also prefer to have remote thumbnails, so I will definitely add that if there's a Google Photos way to do it. I'm testing a few things at the moment, but it takes time to wait out the link expiry (or non-expiry, if it works).

khanhtoan529 commented 1 year ago

I will wait here because I'm not a developer 😅 I hope someone will find this useful and do some work on it.

alangrainger commented 1 year ago

Don't let that stop you - I learned Javascript for a personal project and before that I had never done any development. And I took a Typescript course on Udemy to learn how to make plugins for Obsidian, since I'd never used Typescript before :)