alangrainger / obsidian-google-photos

Connect to Google Photos from Obsidian
GNU General Public License v3.0
93 stars 5 forks source link

Suggestion: save photo ID #9

Closed leoccyao closed 1 year ago

leoccyao commented 1 year ago

I installed this plugin expecting some kind of MarkdownPostProcessor based implementation for displaying photos, and was both gladly surprised and impressed by the simple embed-based format. Though linking to the original photo on Google Photos through the productUrl provides a persistent user-accessible connection to the original photo, there is currently no way to programmatically get the original photo again, as the id is not saved.

This feature request suggests also saving the id of the photo somewhere in the embed syntax. This would enable:

Just saving the photo ID inline is a reasonably simple change, but the embed format can be up to discussion.

The current embed format: [![](link to thumbnail)](productUrl) Possibilities:

I personally do not have a preference, as long as the image preview does not become significantly cluttered.

alangrainger commented 1 year ago

Saving the photo ID will be added as part of request #7 - being able to customise the inserted Markdown.

alangrainger commented 1 year ago

baseUrl and id are now available as variables to use in your own customised Markdown, in v1.1.3.

https://github.com/alangrainger/obsidian-google-photos/releases/tag/1.1.13

For anything additional not covered in this release (e.g. regenerating thumbnails), please submit a pull request.