alangrainger / share-note

Instantly share an Obsidian note with the full theme exactly like you see in your vault. Data is shared encrypted by default, and only you and the person you send it to have the key.
MIT License
276 stars 14 forks source link

Shared note contains metadata footer #62

Closed crepererum closed 8 months ago

crepererum commented 8 months ago

Example: https://share.note.sx/cvhhwxoz#4NhnClbL9l9JmF6uA/p20EywNf4XPRgAK7nWEEADTSU

Scroll to the very bottom. Everything under the horizontal line shouldn't be there. This includes "linked mentioned". I'm seeing this within the app (android, v1.4.16, core module "backlinks" enabled and option "backlink in document" enabled) but it's not part of the note itself. In fact, listing all mentions might easily be a data breach / leak. Also, the footer within the app is interactive but obviously that interactivity wasn't preserved after sharing and the links within the footer are dead (which makes sense).

alangrainger commented 8 months ago

Tough call on this one. I have other tickets requesting that I make that section work including links.

I'm inclined to agree with you though. I might have to add a setting to turn on/off.

crepererum commented 8 months ago

I might have to add a setting to turn on/off.

That sounds like a good compromise and would also be in line with the "remove published frontmatteer/YAML" option which does the same for the "other end".

alangrainger commented 8 months ago

The option to disable the backlinks footer is added in 0.8.5, thanks for the suggestion.