Speed

[samm81]

So I mentioned this earlier, but it runs pretty slowly for me. Part of this is probably because I'm inside of a VM, but then it won't run smoothly on slower computers. It's just text, for crying out loud. I tried to do it the spans way, because I figured that would speed it up, but it didn't. I did some research and I found this: http://andrew.hedges.name/experiments/innerhtml/

This is terrible, because it suggests the cost of setting innerHTML is 60 ms. That's about two frames, which would explain the lag. I think our whole approach might be flawed.

[alanhdu]

Hm...I'm not sure we have many alternatives. Other than displaying text, the only other option I can think of is rendering on a canvas.

Maybe we can try innerText or textContent instead? http://blog.stevenlevithan.com/archives/faster-than-innerhtml has a suggestion for speeding things up too.

Another thing we can try is making the arena a

tag or instead of a <div>. Maybe that way we can avoid any DOM stuff that might be slowing us down?</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/alanhdu"><img src="https://avatars.githubusercontent.com/u/1914111?v=4" />alanhdu</a> commented <strong> 10 years ago</strong> </div> <div class="markdown-body"> <p>Any progress on this?</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/samm81"><img src="https://avatars.githubusercontent.com/u/1221372?v=4" />samm81</a> commented <strong> 10 years ago</strong> </div> <div class="markdown-body"> <p>I've been trying I really have I spent hours last night debugging a compiler issue I found some thing saying that changing the css doesn't cause a DOM recalculation, so I'm trying to use font awesome in order to test if having a class specify the content will speed it up I'm working on it!</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/samm81"><img src="https://avatars.githubusercontent.com/u/1221372?v=4" />samm81</a> commented <strong> 10 years ago</strong> </div> <div class="markdown-body"> <p>So I actually misread that article It was actually saying that changing the class is one of the things the * does * cause a reflow Which can take 1-6 seconds So I just did like hours of work I finally got it working, and it was super slow, then I reread the article and headdesked Oh well On a different note, it's actually really fast now I think the issue was just the server basically When I changed the emit timing from .05 to .025 it worked very, very well If the server can actually handle that, then I think this issue is closed.. But I don't know - I can't push to the heroku server I'm gonna make a quick commit to master bringing it up to 60fps, then if you could push that to heroku that would be nice</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/alanhdu"><img src="https://avatars.githubusercontent.com/u/1914111?v=4" />alanhdu</a> commented <strong> 10 years ago</strong> </div> <div class="markdown-body"> <p>Pushed to Heroku</p> </div> </div> <div class="page-bar-simple"> </div> <div class="footer"> <ul class="body"> <li>© <script> document.write(new Date().getFullYear()) </script> Githubissues.</li> <li>Githubissues is a development platform for aggregating issues.</li> </ul> </div> <script src="https://cdn.jsdelivr.net/npm/jquery@3.5.1/dist/jquery.min.js"></script> <script src="/githubissues/assets/js.js"></script> <script src="/githubissues/assets/markdown.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/highlight.min.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/languages/go.min.js"></script> <script> hljs.highlightAll(); </script> </body> </html>