alanhe421 / alfred-workflows

Save time, Improve life.🚀 ☕️ 💻
https://medium.com/@alanhe421/list/alfred-a65a11fa7a0f
MIT License
645 stars 61 forks source link

[Bug]: error on long filename for cached png #385

Closed eliericha closed 1 year ago

eliericha commented 1 year ago

Describe the bug

Hello,

I encountered this error when using Open Chrome Profile. It seems that Python is unable to write the PNG profile image into the local cache because the path is too long:

[18:54:00.134] Open Chrome Profile[[Script Filter](alfredpreferences:workflows%3Eworkflow%3Euser.workflow.B6C055E2-4BC0-4C6E-9ECE-FF36F8FAD1C8%3EEFB1F57C-ED91-490B-8F0D-534C3102D07E)] Queuing argument '(null)'
[18:54:00.302] Open Chrome Profile[[Script Filter](alfredpreferences:workflows%3Eworkflow%3Euser.workflow.B6C055E2-4BC0-4C6E-9ECE-FF36F8FAD1C8%3EEFB1F57C-ED91-490B-8F0D-534C3102D07E)] Script with argv '(null)' finished
[18:54:00.306] STDERR: Open Chrome Profile[[Script Filter](alfredpreferences:workflows%3Eworkflow%3Euser.workflow.B6C055E2-4BC0-4C6E-9ECE-FF36F8FAD1C8%3EEFB1F57C-ED91-490B-8F0D-534C3102D07E)] Traceback (most recent call last):
  File "/Users/richa/Library/Application Support/Alfred/Alfred.alfredpreferences/workflows/user.workflow.B6C055E2-4BC0-4C6E-9ECE-FF36F8FAD1C8/main.py", line 28, in <module>
    urllib.request.urlretrieve(profil[str(item)]['last_downloaded_gaia_picture_url_with_size'], filename)
  File "/Applications/Xcode.app/Contents/Developer/Library/Frameworks/Python3.framework/Versions/3.9/lib/python3.9/urllib/request.py", line 249, in urlretrieve
    tfp = open(filename, 'wb')
OSError: [Errno 63] File name too long: '/Users/richa/Library/Caches/com.runningwithcrayons.Alfred/Workflow Data/cn.alanhe.open-chrome-profiles/AD_cMMTKTJuJ9fke09N4CzIAG_ZgvXzGQxfX0f15nLQbwaZAz9SH7MHis1qsEYcENb_I_7cR9fIOg0AJqdOp3FVSE59jWvDW0_oakn71oqvELqe2dHQlBM_3hKrOKsvHFG8Y0fv8RTeJoPRy9-RDKJUtG-Jjd-URrPUcd1GcSmczoYuqpzA-Zr2gLKwNfO1XuKBswPoFFDDua0M845_LgyXv-akByWgfWwwwp0jRsNgCg1_WLKo4Nfjs4xQGq5eB0jYL3Su5-pa4-9jV_qEZgqH-Y-UHOzAXSVsYoQr_IpxrVlc8ac-Xhn3tD4dtocSjnETDc4BHoNf38G4-jM6SfrHUty1ilt0wlsgCBGW4Uq3twyCpO3Okm2Nt0y070DBIblOLZ0WOZFb7drMrco9lE2iSMNhR3JY47gd-hymLyWutE2ERfszjwirrZ-dPd8rDfE1EF5-SGPrcHVUm4SytYWcEw2GjinSEuDPxNAYF4I22Zn08aWuHl8sMxgwyElx3szHA9-IrYM3RQbzVdic43zD0OMXxHJgULejqwtFZvBFTCQn_Oa6yOK_Kaq0BXnciRkjLL8Yk3YMOB4dlBsaJ0umI65jpI3Opjb-q4sT2cid4jBDmo8-qE3Q-ekeiRSS4u0_EGgWEdBYGsxOPKyru1G_yC3vu9IObgUqqo5xZE-m6tU_T6jKuIIzvGJR9qiYgYxoNkRkYI_30_nJzuB42GMoXCRAe7U7-YuLeqxuH5QZqMjcnGcc9fLofjcQEvf-tZdM-_XAxBUOBnerU73KFbBSc0tP3QVisylFaWtLWdJaBmGvXvIiT9ComBHGNN-tUPqX_d4f_XqzgLd_d897g_87ku8L-eUtJMhly4kQ0IO6-na79fT5cqfcV-sZolE00YcchGzwlHCKXU-wGLgU-6LxUQ4YUSGRgA0lZsAhxe7Brc39wYliv3IsHBhJZo9FISDH4TGM=s256-c-ns.png'

Moreover, the error displayed by the workflow in this case (/usr/bin/python3 doesn't exist) is not accurate. So that could be improved.

[18:54:00.308] Open Chrome Profile[[Script Filter](alfredpreferences:workflows%3Eworkflow%3Euser.workflow.B6C055E2-4BC0-4C6E-9ECE-FF36F8FAD1C8%3EEFB1F57C-ED91-490B-8F0D-534C3102D07E)] <?xml version="1.0"?>
<items>
  <item arg="error">
    <title>Python3 missing</title>
    <subtitle>/usr/bin/python3 not exist</subtitle>
  </item>
</items>

I intend to submit a pull request to fix this.

Thanks!

Workflow Name

Open Chrome Profile

Alfred Version

v5.1.2

MacOS Version

macOS 13 Ventura

Mac Chip

Apple Silicon (like M1, M2)

MacOS Locale

EN


Workflow Homepage is 👉 Open Chrome Profile