alanhe421 / alfred-workflows

Save time, Improve life.🚀 ☕️ 💻
https://alfred.1991421.cn
MIT License
661 stars 64 forks source link

Monterey Support Planned? #73

Closed EttVenter closed 2 years ago

EttVenter commented 2 years ago

Heya!

Any plans to add Monterey Support? The workflow seems to do nothing at all when executed.

Thanks for your hard work!

alanhe421 commented 2 years ago

which workflow? what's error?

EttVenter commented 2 years ago

Hey!

The airdrop workflow. There's no error, but when I try to use it, literally nothing happens. Any idea why?

Ett Venter Photographer - Instructor - Speaker 082 424 4222 | www.ettventer.com

On 16 Dec 2021, 12:39 PM +0200, Alan.He @.***>, wrote:

which workflow? what's error? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

alanhe421 commented 2 years ago

Not knowing the error and therefore unable to judge, I cannot proceed further.

Only when the specific error is confirmed, can further advancement be necessary.

EttVenter commented 2 years ago

I'm not sure if I was unclear before, but there's no error. There's just nothing that happens.

Ett Venter Photographer - Instructor - Speaker 082 424 4222 | www.ettventer.com

On 19 Dec 2021, 2:20 PM +0200, Alan.He @.***>, wrote:

Not knowing the error and therefore unable to judge, I cannot proceed further — Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android. You are receiving this because you authored the thread.Message ID: @.***>

chrisspiegl commented 2 years ago

I just installed this workflow again and this issue probably relates to #16.

The keyword action to share url/file gave me this error:

Airdrop[Keyword] Processing complete
Airdrop[Keyword] Passing output '' to Run NSAppleScript
Airdrop[Run NSAppleScript] Processing complete
Airdrop[Run NSAppleScript] Passing output 'en_DE' to Arg and Vars
Airdrop[Arg and Vars] Processing complete
Airdrop[Arg and Vars] Passing output 'en_DE' to Run Script
Airdrop[Run Script] Processing complete
Airdrop[Run Script] Passing output 'https://github.com/alanhg/alfred-workflows/issues/73' to Conditional
Airdrop[Conditional] Processing complete
Airdrop[Conditional] Passing output 'https://github.com/alanhg/alfred-workflows/issues/73' to Run Script
ERROR: Airdrop[Run Script] 62:71: execution error: System Events got an error: Can’t set process "Chrome" to true. (-10006)

But when using the Share files with Airdrop File Action it did give this error in the debugger:

ERROR: Airdrop[Run Script] /Users/chrisspiegl/Library/Caches/com.runningwithcrayons.Alfred/Workflow Scripts/26620927-305E-4B38-BDF2-A5C95305533C:876:917: execution error: System Events got an error: Can’t get button 1 of toolbar 1 of window 1 of process "Finder" whose description = "Share". Invalid index. (-1719)

I am on M1 Apple Silicone / Monterey / 12.2 Beta (21D5025f)

EttVenter commented 2 years ago

Yeah, this still isn’t working for me. Any idea why? I tried it now, and upon actioning the “Share Files with Airdrop” action in the files actions menu, nothing happens.

I don’t mean to be a nag, and I’d totally understand if you don’t want to try to figure this out - you don’t owe me anything, lol. I just use airdrop a shit ton, so this would be super useful.

Thanks!

Ett Venter Photographer - Instructor - Speaker 082 424 4222 | www.ettventer.com

On 29 Dec 2021, 09:27 +0200, Chris Spiegl @.***>, wrote:

I just installed this workflow and got this error message: ERROR: Airdrop[Run Script] /Users/chrisspiegl/Library/Caches/com.runningwithcrayons.Alfred/Workflow Scripts/26620927-305E-4B38-BDF2-A5C95305533C:876:917: execution error: System Events got an error: Can’t get button 1 of toolbar 1 of window 1 of process "Finder" whose description = "Share". Invalid index. (-1719)

I am on M1 Apple Silicone / Monterey / 12.2 Beta (21D5025f) — Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android. You are receiving this because you authored the thread.Message ID: @.***>

chrisspiegl commented 2 years ago

@EttVenter I am not the creator of this workflow but I do have this on my todo list as well. Just haven't found the time up to this point. I'll post an update here when I do (or if @alanhg fixes it).

EttVenter commented 2 years ago

Amazing, thank you Chris!

Ett Venter Photographer - Instructor - Speaker 082 424 4222 | www.ettventer.com

On 07 Jan 2022, 11:34 +0200, Chris Spiegl @.***>, wrote:

@EttVenter I am not the creator of this workflow but I do have this on my todo list as well. Just haven't found the time up to this point. I'll post an update here when I do (or if @alanhg fixes it). — Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android. You are receiving this because you were mentioned.Message ID: @.***>

alanhe421 commented 2 years ago

Just have a try for the latest workflow-airdrop.

I found ok on monterey.

If not, reopen, please.

chrisspiegl commented 2 years ago

Hi @alanhg, that's great to hear. Could you update the packaged alfredworkflow files as well? Those seem to be the old ones still.

Thank you 🌸

alanhe421 commented 2 years ago

current is latest. error or not work?

chrisspiegl commented 2 years ago

I tested with this file: https://github.com/alanhg/alfred-workflows/blob/master/airdrop/Airdrop.alfredworkflow

It is 3 Months old (and the src folder in the same folder is 11 days old) with a bunch of changes.

Here is the error message from the Alfred Debug Console:

[14:46:18.622] ERROR: Airdrop[[Run Script](alfredpreferences:workflows%3Eworkflow%3Euser.workflow.6F5919E2-FA6A-4A2C-84B9-7892813EF254%3EE132D993-DFA1-4D18-8E8F-1E19D7073AE2)] /Users/..../Library/Caches/com.runningwithcrayons.Alfred/Workflow Scripts/66089578-8A24-46F4-A975-654013E748D0:876:917: execution error: System Events got an error: Can’t get button 1 of toolbar 1 of window 1 of process "Finder" whose description = "Share". Invalid index. (-1719)
alanhe421 commented 2 years ago

I tested with this file: https://github.com/alanhg/alfred-workflows/blob/master/airdrop/Airdrop.alfredworkflow

It is 3 Months old (and the src folder in the same folder is 11 days old) with a bunch of changes.

Here is the error message from the Alfred Debug Console:

[14:46:18.622] ERROR: Airdrop[[Run Script](alfredpreferences:workflows%3Eworkflow%3Euser.workflow.6F5919E2-FA6A-4A2C-84B9-7892813EF254%3EE132D993-DFA1-4D18-8E8F-1E19D7073AE2)] /Users/..../Library/Caches/com.runningwithcrayons.Alfred/Workflow Scripts/66089578-8A24-46F4-A975-654013E748D0:876:917: execution error: System Events got an error: Can’t get button 1 of toolbar 1 of window 1 of process "Finder" whose description = "Share". Invalid index. (-1719)

Please mark out the version and other information according to the submission requirements of issue.

  1. Mac version and language
  2. Alfred version
  3. Workflow version

Don't worry about the date of the file, just the version for development, and I'm sure the Workflow file is up to date.

chrisspiegl commented 2 years ago
  1. Mac version and language: 12.3 (M1 Max / English)
  2. Alfred version: 4.6.5 [1298]
  3. Workflow version: v1.7

When I open Alfred and type airdrop and hit Enter I simply get a notification that i should select a file or url. It does not give me an option to filter for file or anything. Not sure what that specific Keyword Input is supposed to do.

When I have a url in the clipboard it does not show the notification but also nothing happens.

When I open the Share Files with… action on a File Action in Alfred and hit enter, I get the error message I posed before:

Airdrop[File Action] Passing output '/Users/chrisspiegl/Desktop/a.jpg' to Run NSAppleScript
Airdrop[Run NSAppleScript] Processing complete
Airdrop[Run NSAppleScript] Passing output 'en_DE' to Arg and Vars
Airdrop[Arg and Vars] Processing complete
Airdrop[Arg and Vars] Passing output 'en_DE' to Conditional
Airdrop[Conditional] Processing complete
Airdrop[Conditional] Passing output 'en_DE' to Run Script
ERROR: Airdrop[Run Script] /Users/chrisspiegl/Library/Caches/com.runningwithcrayons.Alfred/Workflow Scripts/66089578-8A24-46F4-A975-654013E748D0:876:917: execution error: System Events got an error: Can’t get button 1 of toolbar 1 of window 1 of process "Finder" whose description = "Share". Invalid index. (-1719)
alanhe421 commented 2 years ago

maybe en_DE diff from en_US.

can you try en_US?

chrisspiegl commented 2 years ago

I switched the language and region to EN USA

Same error from what I can tell:

Airdrop[Arg and Vars] Processing complete
Airdrop[Arg and Vars] Passing output 'en_US' to Conditional
Airdrop[Conditional] Processing complete
Airdrop[Conditional] Passing output 'en_US' to Run Script
ERROR: Airdrop[Run Script] /Users/chrisspiegl/Library/Caches/com.runningwithcrayons.Alfred/Workflow Scripts/66089578-8A24-46F4-A975-654013E748D0:876:917: execution error: System Events got an error: Can’t get button 1 of toolbar 1 of window 1 of process "Finder" whose description = "Share". Invalid index. (-1719)

Here is a screenshot of the Finder Menu:

Capture 2022-04-07 at 5 04 25 PM
alanhe421 commented 2 years ago

image

you see here.

workflow depends it.

chrisspiegl commented 2 years ago

Interesting, why not make it depend on the menu bar item? I personally have all the finder toolbar things hidden to have the design be clean. The Menubar feels like it would be more reliable to depend on?