search

alanhuang122 / fl-oneclick-wiki

Simple extension to save you the click on opening "Fallen London" Wiki
MIT License
16 stars 8 forks source link

[Bug] Wiki button opens seven tabs for the zee-dreams #23

Open umbralOptimatum opened 1 year ago

umbralOptimatum commented 1 year ago

The zee dreams are implemented as text variants of the same card, while the wiki records them as seven different pages all using the same ID. Using the one-click wiki button for a zee-dreams card opens all seven pages with matching IDs, not just the one for the current dream level.

For situations like this, I would expect the extension should primarily search for pages by ID but, if multiple pages exist for that ID, only open one(s) that match the current branch name.

lensvol commented 1 year ago

I believe it's the same type of issue as described in #14. Workaround with using branch's name seems promising, I will see if something can be done with it.

umbralOptimatum commented 1 year ago

Whoops, yes, same issue. One thought for future-proofing: if there isn't an exact match for the title, would it make sense to try filtering on title inclusion before last-resort opening every page with matching ID? I'm thinking of storylet designs like Arbor; if the wiki didn't have a disambiguation page named "Far Arbor", it would make sense to filter the results to titles including "Far Arbor" (Far Arbor (Temple), Far Arbor (North), etc) to not open every Near Arbor page as well.

lensvol commented 1 year ago

As far as I can see, my current change set is actually already doing that - clicking on the Wiki button opens several pages, but they are all related to Far Arbor.

umbralOptimatum commented 1 year ago

Ah whoops, I thought Near and Far Arbor had the same ID. Works for now then, and hopefully the wiki will never need to implement a storylet with such complexity.