Configurability

[jason-curtis]

supercedes #14 sorry for the gigantic PR...

• moves all configuration to one config file (closes #7) with schema validation.
• makes location configurable (closes #11)
  • I've allowed configuration based on a city name if Astral recognizes it, or the full-on lat/lon/elevation/tz config for places like Fairhaven that are too small for Astral's library. I might have only manually tested the detailed-config version...
  • Structurally, this meant making an astral.Location object up front in main() and then passing it around. That was handy.
• adds setup.py so there's a "real" command-line entry point. unlocks #1 - just have to set it up on a pypi account now. Might also want to add an entry point for twitter.py
  • In trying to figure out the package name, I standardized all files and names to be either golden_hour (python module name) or golden-hour (repo name and console scripts). Until then there was some inconsistency. Twitter handles are still recommended to be goldenhourXYZ.
• adds recommended cron job configuration (closes #4)
• README updates for the above

Testing

Not extensive :see_no_evil: ! I've been running the fairhaven camera off of a slightly earlier version of this branch for the last few days. I also ran tweet.py and checked that it worked with both and old-style and new-style config file.

[jason-curtis]

own thoughts after using this:

• --config-file is required and kinda long, so it makes the command always pretty bulky to type. It should (a) have a default value and/or (b) be a positional argument and/or (c) a short option -c. Leaning towards (a) and (c).
  • this should follow through to the golden-hour-tweet command too, which maybe should drop support for old-style config files since that makes it a little complex to use.
• might want to only check twitter credentials if we're posting to twitter

[alanhussey]

This is great! I won't be able to get to this for a couple days, but I'll try to do that soon.

[jason-curtis]

OK, this is probably ready to merge, though it also may be worth squashing first! https://twitter.com/FairhavenSunset has been running off of a pretty recent commit for a while. Could wait till tomorrow when it's run off of the very latest.

[alanhussey]

Thank you!!!!