search

alanjuden / MvcReportViewer

Custom Report Viewer control to replace MS Report Viewer on MVC projects (also works on .NET Core as a Report Viewer).
MIT License
173 stars 109 forks source link

Boostrap 4 Support #96

Closed sgopimca7 closed 4 years ago

sgopimca7 commented 4 years ago

Thanks for this great tool.

As of now we are using bootstrap 4.3.1.

The Report Viewer screen great when we use the bootstrap 3 version, But the design breaks when we use the bootstrap 4.3.1.

Boostrap 3:

Boostrap 3

Boostrap 4:

Boostrap 4

Please help on this issue.

Thanks and Regards,

Gopi.S

tiesont commented 4 years ago

The markup this class generates was not really valid before, but Bootstrap 3's styles would let it more or less work as intended. With the updates that Bootstrap 4 introduced to the grid system, the layout is breaking how it probably should have before.

What's my point, then? Well, someone just needs to update that class to generate the correct grid markup, and then it should work on both versions of Bootstrap. I'd imagine it wouldn't be too difficult of a pull-request.