search

alanmcgovern / Mono.Nat

UPNP and NAT-PMP port forwarding for .NET
https://github.com/mono/Mono.Nat
MIT License
163 stars 156 forks source link

Upstream nterry changes #6

Closed alanmcgovern closed 5 years ago

alanmcgovern commented 5 years ago

/cc @nterry

nterry commented 5 years ago

@alanmcgovern Holy crap! I never expected these changes to get merged. I honored!

Out of curiosity, what prompted you to bring in the changes after all this time?

nterry commented 5 years ago

@alanmcgovern Also, Id be happy to transfer the cicd stuff to you so this can be the official distribution if that is of interest to you. Id have to work out how to to that, but id be willing to

nterry commented 5 years ago

@alanmcgovern Can you amend that email to nick.i.terry@gmail.com in the authors? I no longer have access the one currently in the file

alanmcgovern commented 5 years ago

What really happened is that i forgot about the repo after the previous conversation (and PR) a few years back :p

I need this lib for something I'm working on and realised that the router I have has some bugs and i need to hack up the library to make it work right. I looked through the PRs, saw yours, figured i may as well merge it in case it solved my problem. Unfortunately it didn't, but it is what it is!

If there's still active CI on this, then it might be easier to just add you as a contributor to this repo and transition things from your fork to this repo. I'll add you as a contributor anyway :p

alanmcgovern commented 5 years ago

(Though it is fine if you never touch the repo again, even with read/write access! :p I doubt i'll do a huge amount of patching other than making this work with my rather unique router issues :p )