Complete IPV6 support - Githubissues

alanmcgovern / monotorrent

The official repository for MonoTorrent, a bittorrent library for .NET

https://github.com/alanmcgovern/monotorrent

MIT License

1.14k stars 396 forks source link

Complete IPV6 support #588

Open alanmcgovern opened 1 year ago

alanmcgovern commented 1 year ago

There are a few things I need to update to fully support ipv6. This includes:

[x] Fix Uri creation for IPV6 peers ( https://github.com/alanmcgovern/monotorrent/pull/589 )
[x] Add support for binding to ipv4 and ipv6 listening endpoints ( https://github.com/alanmcgovern/monotorrent/pull/590 )
[x] Update UDP tracker support with the unofficial extension to support ipv6 (https://www.bittorrent.org/beps/bep_0007.html and http://opentracker.blog.h3q.com/2007/12/28/the-ipv6-situation/ and http://www.bittorrent.org/beps/bep_0015.html , https://github.com/alanmcgovern/monotorrent/pull/594)
[x] Update HTTP tracker with the draft BEP covering the newer ipv6 mechanism (https://www.bittorrent.org/beps/bep_0007.html) https://github.com/alanmcgovern/monotorrent/pull/594
[ ] Support IPv6 DHT (http://bittorrent.org/beps/bep_0032.html)
[x] Add support for specifying reported IP addresses for both ipv4 and ipv6 ( https://github.com/alanmcgovern/monotorrent/pull/590 )
[x] Support ipv4/ipv6 PEX ( https://www.bittorrent.org/beps/bep_0011.html ) ( https://github.com/alanmcgovern/monotorrent/pull/593 )
[x] Ensure ipv6 compact peers can be encoded/decoded ( https://github.com/alanmcgovern/monotorrent/pull/592 )

ycy1164656 commented 1 year ago

nice work,Im currently on vacation,but really looking forward to your accomplishment

ycy1164656 commented 1 year ago

I added

AllowedEncryption = new[] { EncryptionType.PlainText },

in both monotorrent sampleclients on two computers,

one can connect to another, but the other one can not connect back

then ,nothing happened after this.

alanmcgovern commented 1 year ago

Interesting!

In my own testing I just checked that monotorrent can make an outgoing IPV6 connection to qbittorrent, and successfully transfer data. I didn't check if monotorrent handled incoming IPV6 connections from qbittorrent, or from another monotorrent client. I also didn't validate the behaviour of monotorrent being a seeder or leecher.

My strategy is to thread IPv6 support (as per various BEPs) through the engine, and then augment the integration tests contributed by @borigas to validate both ipv4 and ipv6 connections end-to-end.

Once the IPv6 variants of these tests are green, you should be good to go!

ycy1164656 commented 1 year ago

Interesting!

In my own testing I just checked that monotorrent can make an outgoing IPV6 connection to qbittorrent, and successfully transfer data. I didn't check if monotorrent handled incoming IPV6 connections from qbittorrent, or from another monotorrent client. I also didn't validate the behaviour of monotorrent being a seeder or leecher.

My strategy is to thread IPv6 support (as per various BEPs) through the engine, and then augment the integration tests contributed by @borigas to validate both ipv4 and ipv6 connections end-to-end.

Once the IPv6 variants of these tests are green, you should be good to go!

brilliant ，really appreciate your work

alanmcgovern commented 1 year ago

@ycy1164656 I've just finalised this work (except for IPv6 DHT support).

https://github.com/alanmcgovern/monotorrent/pull/614

If you're comfortable testing code from git, could you check out that branch and see if everything works well for your case now?