search

alanmoo / jobsearch-community

Issues for my intentional job search app
0 stars 0 forks source link

[feature] "Toggle all" functionality #1

Open jsonunger opened 2 months ago

jsonunger commented 2 months ago

I think instead of the Toggle all functionality that you currently have, you might be better suited by having this be a "select all"/"unselect all" functionality similar to Gmail. The Toggle all functionality is weird since it just inverts the selection and I don't necessarily see a use case for doing that other than selecting or unselecting all of the jobs on the page.

https://github.com/alanmoo/jobsearch-community/assets/16748392/1d194641-e61c-4a8b-aaa5-299ffe8055c0

alanmoo commented 2 months ago

Ah, yes- that was a "let me write some quick code and move on" MVP functionality.

Two other features I was thinking about to improve searching:

1.) Ability to action on each role 2.) Move the toggle all/select all button to the bottom so you can decide after you look.

I suspect 2 is useful (and simpler), so it's worth doing even if I eventually get to 1. Do you agree?

jsonunger commented 2 months ago

I would say at the very least colocating the toggle/select capability and the actions you can take is the right idea. Whether you put them all at the bottom or the top can depend. If you put everything at the top but had it sticky so that it’s always visible on the scroll, the benefit is that you’d have all of your actions and inputs bundled together between the search capability and the actions.

I think being able to action individual roles is definitely advantageous, but agreed that with only 10 jobs per view it’s not as immediately critical.

alanmoo commented 2 months ago

I've corrected the behavior and moved the button to the bottom, which should improve usability. I'm going to hold off on any more changes until I have a proper UI plan. Does this work for now to close?