search

alanning / MongoProviders

ASP.NET Membership and Role Providers for MongoDB
MIT License
44 stars 20 forks source link

MongoCSharpDriver 1.4.2 now has fluent extensions #1

Open gavinkilbride opened 12 years ago

gavinkilbride commented 12 years ago

I updated the assemblies for the MongoCSharpDriver and FluentMongo but this broke the unit tests. FluentMongo had a dependency on version 1.3.1. I therefore removed the reference to FluentMongo and used the MongoCSharpDriver extension methods for chaining (no code change, just references) and it all works beautifully. Just thought I'd let you know in case someone else did the same. Great work btw and will let you know how my little project goes, if interested :) This has just saved me days of work. Thank you very much.

alanning commented 12 years ago

Thanks Gavin. Glad you found it useful!

I'm actually on vacation now... Do you think you could submit a pull request with your changes? :-)

Out of curiosity would a Nuget package be useful? I have one for a related project, MongoWSAT (https://nuget.org/packages/MongoWSAT) but not for this one.

On Thu, May 10, 2012 at 9:07 AM, Gavin Kilbride reply@reply.github.com wrote:

I updated the assemblies for the MongoCSharpDriver and FluentMongo but this broke the unit tests. FluentMongo had a dependency on version 1.3.1. I therefore removed the reference to FluentMongo and used the MongoCSharpDriver extension methods for chaining (no code change, just references) and it all works beautifully. Just thought I'd let you know in case someone else did the same. Great work btw and will let you know how my little project goes, if interested :) This has just saved me days of work. Thank you very much.

Reply to this email directly or view it on GitHub: https://github.com/alanning/MongoProviders/issues/1

gavinkilbride commented 12 years ago

Hi Adrian Us Microsoft developers love it when our life is made easy so yes a Nuget package would be most welcome. I suspect a few more people may stumble across it this way too. The first thing I do when looking for a third party solution is search Nuget. It was only when finding nothing suitable on Nuget that I Googled "Mongo Role Provider".

Although I've never done one before I'll happily do a pull request, it's a trivial change. Thanks for your efforts.

Gav

alanning commented 12 years ago

Hi Gav,

I'm back from vacation and just merged in your pull-request. Thank you!

Was hoping to get your take on including the mongo driver dll directly vs. using a nuget dependency. It is currently included directly with the rationale being that it makes the installation faster. The nuget package for the mongo driver pulls down a lot of unnecessary stuff so it takes quite a while. It would simplify the MongoProviders Nuget package to use a dependency, though, so I'm leaning towards changing it.

Another consideration is that most dev's using the MongoProviders package would probably already have the mongo driver package for use with their regular db storage code.

What's your feeling?

efosao commented 12 years ago

Many thanks for this project Adrian,

It's been a great time-saver!

Just to chime in on that question, I'd recommend using a 'reference' (rather than embedding the dll) for the nuget package.

alanning commented 12 years ago

Hi Efosa,

Thanks for the input and I'm glad this was able to save you some time! I agree with your points so that's what we'll do. I'll post back here once the Nuget package is up (early next week).

Cheers!

On Fri, May 18, 2012 at 5:08 PM, Efosa Oyegun reply@reply.github.com wrote:

Many thanks for this project Adrian,

It's been a great time-saver!

Just to chime in on that question, I'd recommend using a 'reference' (rather than embedding the dll) for the nuget package.

  • The reason being that if you are using nuget to manage the MongoProvider, odds are that you also used it to install the Mongo driver in the first place, and also
  • While having the mongo driver dll might get you started faster, it might be an inconvenience down the road when updating the components separately.

Reply to this email directly or view it on GitHub: https://github.com/alanning/MongoProviders/issues/1#issuecomment-5795832

efosao commented 12 years ago

Thanks Adrian!