search

alanorth / hugo-theme-bootstrap4-blog

A blogging-centric Bootstrap v4 theme for the Hugo static site generator.
Other
204 stars 132 forks source link

Added 'header_visible' parameter to allow switching off the header. #102

Closed ghost closed 6 years ago

ghost commented 6 years ago

Some users (like me) may want to hide the header with the site's title. I added a configuration parameter, header_visible (default true).

alanorth commented 6 years ago

Sure, I don't mind this change. See my one comment.

Also, next time you should make the changes in a feature branch of your repository, like no-header or something, instead of master so that your repository doesn't get out of sync with mine (aka the upstream master) when I make other changes or merge other pull requests.

ghost commented 6 years ago

Thanks for the feedback! I made the changes and will use a branch next time.

alanorth commented 6 years ago

Hello, I manually cherry-picked your two commits directly to master to avoid merging your branch history. Thanks!