search

alanorth / hugo-theme-bootstrap4-blog

A blogging-centric Bootstrap v4 theme for the Hugo static site generator.
Other
204 stars 132 forks source link

Fixed invalid URL if blog is not in domain root #115

Closed phofman closed 5 years ago

phofman commented 5 years ago

It fixes a problem with a site, that resides not on domain root, i.e. https://domain.com/blog 'Title' of each page should lead then to /blog URL instead it navigates directly to the root.

alanorth commented 5 years ago

Good catch, @phofman. This is a safer way to do this. I will just cherry-pick the first commit with the fix instead of merging the pull request because I see you've pushed unrelated commits to your master branch. In the future you should make pull requests from a feature/topic branch on your repository. Thank you.

Having said that, I do have a blog using this theme where the blog is not at the root and it works fine with the current "/" link. I don't understand why that works. :laughing:

phofman commented 5 years ago

Sorry, I should have created a dedicated branch for only the first commit. Other changes are strictly related to my blog though.

Thanks!