search

alanorth / hugo-theme-bootstrap4-blog

A blogging-centric Bootstrap v4 theme for the Hugo static site generator.
Other
204 stars 132 forks source link

blockquotes aren't distinguished at all #50

Closed xenoterracide closed 7 years ago

xenoterracide commented 7 years ago

This post has a number of blockquotes, none of which have different formatting and so you can't tell what's being quoted. screenshot contains quoted and unquoted text.

image

image

alanorth commented 7 years ago

Ah, yes, this is unfortunate. Bootstrap's blockquote syntax requires class blockquote in order to apply styling, see this example:

screen shot 2017-03-16 at 11 50 53-fs8

So the HTML code that Hugo generates for Markdown-style blockquotes doesn't get style applied when using Bootstrap's default config.

alanorth commented 7 years ago

Thanks @xenoterracide. Fixed in https://github.com/alanorth/hugo-theme-bootstrap4-blog/commit/132d659955a1fbbda88c29df7b58f0035f5cfe8b by applying Bootstrap's same style to all <blockquote> tags.

xenoterracide commented 7 years ago

Thanks :D I might consider filing a bug with bootstrap too.. because I notice this is a change from 3.x, and I'm not sure that it needs to be.