search

alanpich / tvImagePlus

Advanced Image TV type for ModX 2.2+
18 stars 33 forks source link

Does not render properly in 2.3.2 #74

Open ghost opened 9 years ago

ghost commented 9 years ago

Revo 2.3.2, Image+ 2.2.0 beta. rendering_232

exside commented 9 years ago

jap, it's a mess and my bad in part (like in re-doing the inputs for 2.3)... wanted to fix this myself in spare time but currently I dont have such thing^^

ghost commented 9 years ago

Unfortunately I don't have enough understanding of the ExtJS/Smarty stuff to be able to figure out what's going on. I'm making progress slowly, but not up to something like this yet.

alanpich commented 9 years ago

wow... yeah i can see that being a bit of an issue for usability.... sorry i've been absent on this project for a (long) while; I've been elsewhere and distracted etc etc.

From the screenshot it looks like a clash between the css hacks that were put in place (by me) to sort layout issues in the 2.2* releases against the nice new structured styles of the 2.3 releases. I doubt it's ExtJs causing that top-margin issue - take a look at the image+ stylesheets.

The clipping of the icon on the right hand side of the screenshot is definitely caused by the ExtJs framework - it uses explicit container widths for all panels and clips anything that overflows.

Has anyone got a fork of this fix on the go for 2.3 or do i need to brush the dust off my Modx?

ghost commented 9 years ago

Well, I'm right now struggling with git and github to submit a couple of small fixes to minor issues in the MODX core. Once I get that under control and begin to understand what I'm doing, I'll see what I can do with this. I've never used it, but it seems like a very useful add-on.

ghost commented 9 years ago

If I fork this (already done), do I clone it, then set it up like the "doodles" tutorial, using something like the rtfm has here http://rtfm.modx.com/revolution/2.x/case-studies-and-tutorials/developing-an-extra-in-modx-revolution#DevelopinganExtrainMODXRevolution-MakingtheMagicPathSettings or is there a way to be able to have it installed in a MODX installation and work on it? I can set up a MODX Cloud repository if that would be helpful.

yuka123 commented 9 years ago

sottwell you don't have to do that in the "doodles" tutorial. It's far more simpler. You fork this repo to your account. Then there is a _build as you can see in the repo. Just set it up in your webserver directory and run it. It will create the latest package. Now this puts everything in place already for you to work on the issues.(ofc you have to install the package) Once you create any changes on your local installation of the build you can just push those to your repo and propous the pull request to the original repo.

Best, yuka

Jako commented 9 years ago

Have done some compatibility work on the 2.2.0 version from MODX Extras and commited it to master on https://github.com/Jako/ImagePlus.

The folder renaming was somehow necessary to use GitPackageManagement for build. At that time I changed tvimageplus to imageplus in the whole package.

The main changes here:

Maybe they are also valid for 3.0.x branch.